On Mon, Jul 15, 2024 at 02:15:39PM +0200, Stephan Gerhold wrote: > The backlight does not work correctly with the current display panel > configuration: It works after boot, but once the display gets disabled it > is not possible to get it back on. It turns out that the ATNA45AF01 panel > needs exactly the same non-standard power sequence as implemented by the > panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. > > Switch the panel in the DT to the new compatible and make two more changes > to make it work correctly: > > 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and > enable-gpios in the DT). > 2. Drop the regulator-always-on for the panel regulator. The panel does > not seem to power off properly if the regulator stays on. > > Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> > --- > This can be applied as fix for 6.11 since the driver works as-is with the > fallback compatible. If so, the defconfig patch should ideally also go > there to ensure people actually have the driver enabled. Verified that I can change the brightness setting and that the backlight comes on again after being turned off (e.g. at suspend): Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx> Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>