Hi Archit, Thank you for the patch. On Wednesday 09 Mar 2016 16:27:18 Archit Taneja wrote: > Add description of ADV7533. Add the required and optional properties that > are specific to it. > > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Archit Taneja <architt@xxxxxxxxxxxxxx> > --- > .../bindings/display/bridge/adi,adv7511.txt | 25 ++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt > b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt index > 96c25ee..420da5a 100644 > --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt > +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt > @@ -1,13 +1,19 @@ > -Analog Device ADV7511(W)/13 HDMI Encoders > +Analog Device ADV7511(W)/13/33 HDMI Encoders > ----------------------------------------- > > -The ADV7511, ADV7511W and ADV7513 are HDMI audio and video transmitters > +The ADV7511, ADV7511W, ADV7513 and ADV7533 are HDMI audio and video > transmitters compatible with HDMI 1.4 and DVI 1.0. They support color space > conversion, -S/PDIF, CEC and HDCP. > +S/PDIF, CEC and HDCP. ADV7533 supports the DSI interface for input pixels, > while +the others support RGB interface. > > Required properties: > > -- compatible: Should be one of "adi,adv7511", "adi,adv7511w" or > "adi,adv7513" +- compatible: Should be one of: > + "adi,adv7511" > + "adi,adv7511w" > + "adi,adv7513" > + "adi,adv7533" > + > - reg: I2C slave address > > The ADV7511 supports a large number of input data formats that differ by > their @@ -32,6 +38,11 @@ The following input format properties are required > except in "rgb 1x" and - adi,input-justification: The input bit > justification ("left", "evenly", "right"). > > +The following properties are required for ADV7533: > + > +- adi,dsi-lanes: Number of DSI data lanes connected to the DSI host. It > should + be one of 1, 2, 3 or 4. Does the ADV7533 support data lanes remapping ? > Optional properties: > > - interrupts: Specifier for the ADV7511 interrupt > @@ -42,13 +53,17 @@ Optional properties: > - adi,embedded-sync: The input uses synchronization signals embedded in the > data stream (similar to BT.656). Defaults to separate H/V synchronization > signals. > +- adi,disable-timing-generator: Only for ADV7533. Disables the internal > timing + generator. The chip will rely on the sync signals in the DSI data > lanes, + rather than generate its own timings for HDMI output. Isn't that something that should be selectable at runtime ? > Required nodes: > > The ADV7511 has two video ports. Their connections are modelled using the > OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > -- Video port 0 for the RGB or YUV input > +- Video port 0 for the RGB, YUV or DSI input. In the case of ADV7533, the > + remote endpoint phandle should refer to a valid mipi_dsi_host device Nitpicking, I would write "reference" instead of "refer to". > node. - Video port 1 for the HDMI output -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html