On Thu, Jul 11, 2024 at 10:13:38AM +0200, Konrad Dybcio wrote: > On 11.07.2024 10:11 AM, Konrad Dybcio wrote: > > On 11.07.2024 7:49 AM, Ankit Agrawal wrote: > >> On Wed, Jul 10, 2024 at 01:54:01PM +0200, Konrad Dybcio wrote: > >>> On 10.07.2024 1:08 PM, Ankit Agrawal wrote: [...] > > We should probably also check if msm_timer_init() succeeds and unmap > if that fails.. we can just check the return value of that function > and if it's non-zero, call iounmap Sure. I have updated the patch accordingly. Please find version 2 of the patch here: https://lore.kernel.org/linux-arm-msm/20240712082747.GA182658@bnew-VirtualBox/ Thanks! Ankit