On 7/10/2024 12:28 AM, Bjorn Helgaas wrote:
On Tue, Jul 09, 2024 at 10:53:43PM +0800, Tengfei Fan wrote:
Add devicetree bindings support for QCS9100 SoC. It has DMA register
space and dma interrupt to support HDMA.
s/dma/DMA/ above for consistency.
This update will be included in the next verion of the patch series.
Add blank line here if this is a paragraph break.
A blank line will be added in the next verion of the patch series.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,qcs9100-pcie-ep" to describe non-SCMI
based PCIe.
s/drived/derived/
This update will be included in the next verion of the patch series
This patch doesn't add anything related to SCMI, so this paragraph
seems like a distraction.
This patch is used to support QSC9100. QCS9100 uses non-SCMI resources,
so there is nothing related to SCMI in this patch.
Only SA8775p will move to use SCMI resources in the future.
The first paragraph seems a bit of a distraction too, since the patch
doesn't say anything about DMA register space or interrupt.
I will update this commit message as follows in the next version of the
patch series.
"Add devicetree bindings support for QCS9100 PCIe EP compatible."
Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
---
Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
index 46802f7d9482..8012663e7efc 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
@@ -13,6 +13,7 @@ properties:
compatible:
oneOf:
- enum:
+ - qcom,qcs9100-pcie-ep
- qcom,sa8775p-pcie-ep
- qcom,sdx55-pcie-ep
- qcom,sm8450-pcie-ep
@@ -203,6 +204,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,qcs9100-pcie-ep
- qcom,sa8775p-pcie-ep
then:
properties:
--
2.25.1
--
Thx and BRs,
Tengfei Fan
