On 7/9/2024 5:19 AM, Konrad Dybcio wrote: > On 8.07.2024 11:14 PM, Sagar Cheluvegowda wrote: >> Define interconnect properties for ethernet hardware. >> >> Suggested-by: Andrew Halaney <ahalaney@xxxxxxxxxx> >> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@xxxxxxxxxxx> >> --- >> Adding interconnect dtsi properties within ethernet node of SA8775P, >> this patch is adding support for the interconnect properties defined >> in the series -> >> https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@xxxxxxxxxxx/ >> --- >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> index 23f1b2e5e624..7ebf03953b7b 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> @@ -3464,6 +3464,12 @@ ethernet1: ethernet@23000000 { >> "ptp_ref", >> "phyaux"; >> >> + interconnect-names = "mac-mem", "cpu-mac"; >> + interconnects = <&aggre1_noc MASTER_EMAC_1 QCOM_ICC_TAG_ALWAYS >> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, >> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS >> + &config_noc SLAVE_EMAC1_CFG QCOM_ICC_TAG_ALWAYS>; > > property > property-names > > please > > otherwise lgtm > > Konrad Thanks Konrad Dybcio for reviewing, let me post a new patch re-ordering the properties.
