On 7/5/24 08:55, Krzysztof Kozlowski wrote: > On 04/07/2024 22:02, Adam Skladowski wrote: >> Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. >> >> Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx> >> --- >> .../bindings/interconnect/qcom,msm8976.yaml | 63 ++++++++++++ >> .../dt-bindings/interconnect/qcom,msm8976.h | 97 +++++++++++++++++++ >> 2 files changed, 160 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8976.yaml >> create mode 100644 include/dt-bindings/interconnect/qcom,msm8976.h >> > This is not a valid path. Please correct it, otherwise tools cannot > validate it. Somehow got this weird idea out of qcom,msm8953.yaml seems its wrong over there too. Should proper line be like? : See also:: include/dt-bindings/interconnect/qcom,msm8976.h >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,msm8976-bimc >> + - qcom,msm8976-pcnoc >> + - qcom,msm8976-snoc >> + >> + reg: >> + maxItems: 1 >> + >> + '#interconnect-cells': >> + const: 2 >> + > I don't know what and why happened here. I asked for different order of > properties and properties are gone. Provide detailed changelog. For disappearing props it turns out clocks which i had defined for it aren't required so these were wiped from yaml+driver. >> +patternProperties: >> + '^interconnect-[a-z0-9\-]+$': >> + type: object >> + $ref: qcom,rpm-common.yaml# >> + unevaluatedProperties: false >> + description: >> + The interconnect providers do not have a separate QoS register space, >> + but share parent's space. >> + >> + properties: >> + compatible: >> + const: qcom,msm8976-snoc-mm >> + >> + required: >> + - compatible >> + - '#interconnect-cells' >> + >> +required: >> + - compatible >> + - reg >> + - '#interconnect-cells' >> + > > So no schema? Sorry, this is very confusing. > > I am not going to review the rest. You implemented some odd changes, not > what was asked. At least not entirely. With no changelog explaining > this, you basically expect me to do review from scratch like there was > no previous review. > > That's not how it works. > > Best regards, > Krzysztof > As both yamls will not differ much from qcom,msm8939.yaml i moved compatibles in it for v3. Would be great to discuss it before resending on #linux-msm
