On Wed, Jul 03, 2024 at 11:17:01PM GMT, Taniya Das wrote: > > > On 6/21/2024 10:03 AM, Taniya Das wrote: > > > Please merge this into one to save on boilerplate, take a look > > > at dispcc-sc8280xp.c > > > > > > > I did take a look at the dispcc for SC8280XP before posting the series, > > but it kind of looked tricky to add fixes for a particular dispcc. > > Debugging could also be difficult in my opinion. > > Though I understand that we are trying to optimize by re-using few > > common structures/probe but from clocks side they are all redefined. > > That was the reason to keep them separate. > > Konrad, are you good with the proposal to keep the two instance of display > clock controllers as separate drivers? As I looking to post > the next patch series, please let me know your comments. I'd say, continue with the separate drivers. -- With best wishes Dmitry