On 04/07/2024 09:39, neil.armstrong@xxxxxxxxxx wrote:
[ ... ]
OK I just found out, it's the `qcom-battmgr-bat` thermal zone, and in CI
we do not have the firmwares so the
temperature is never available, this is why it fails in a loop.
Before this patch it would fail silently, but would be useless if we
start the firmware too late.
So since it's firmware based, valid data could arrive very late in the
boot stage, and sending an
error message in a loop until the firmware isn't started doesn't seem
right.
Yeah, there was a similar bug with iwlwifi. They fixed it by registering
the thermal zone after the firmware was successfully loaded.
Is that possible to do the same ?
I think Rafael's new patch is good, but perhaps it should send an error
when it finally stops monitoring.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog