On 29/06/2024 10:22, Luca Weiss wrote:
> On Freitag, 28. Juni 2024 20:32:39 MESZ Vikram Sharma wrote:
>> This change enables IMX577 sensor driver for qcm6490.
>>
>> Signed-off-by: Hariram Purushothaman <quic_hariramp@xxxxxxxxxxx>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
>> ---
>> drivers/i2c/busses/i2c-qcom-cci.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
>> index 414882c57d7f..10e6df566ae3 100644
>> --- a/drivers/i2c/busses/i2c-qcom-cci.c
>> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
>> @@ -817,6 +817,7 @@ static const struct of_device_id cci_dt_match[] = {
>> * Do not add any new ones unless they introduce a new config
>> */
>> { .compatible = "qcom,msm8916-cci", .data = &cci_v1_data},
>> + { .compatible = "qcom,sc7280-cci", .data = &cci_v2_data},
>
> Please read the comment above qcom,msm8916-cci.
>
> And sc7280.dtsi already uses
>
> compatible = "qcom,sc7280-cci", "qcom,msm8996-cci";
>
> So qcom,msm8996-cci with the same match data (cci_v2_data) gets used, so
> just drop this patch.
>
I think we put quite obvious comment, yet it is ignored.
Any ideas how to change the comment so people will read it?
Best regards,
Krzysztof
