On 29.06.2024 11:01 AM, Luca Weiss wrote: > On Donnerstag, 27. Juni 2024 21:30:52 MESZ Raymond Hackley wrote: >> Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the >> other Samsung devices based on MSM8226 with only a few minor differences. >> >> The device trees contain initial support with: >> - GPIO keys >> - Regulator haptic >> - SDHCI (internal and external storage) >> - UART (on USB connector via the TI TSU6721 MUIC) >> - Regulators >> - Touchscreen >> - Accelerometer >> >> Signed-off-by: Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx> >> --- [...] >> + haptic { >> + compatible = "regulator-haptic"; >> + haptic-supply = <®_motor_vdd>; >> + min-microvolt = <3300000>; >> + max-microvolt = <3300000>; >> + }; > > This is the vibration motor? Use "vibrator" as node name then as per > https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter2-devicetree-basics.rst?plain=1#L299 With that: Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad