On 28.06.2024 1:30 PM, Xilin Wu via B4 Relay wrote:
> From: Xilin Wu <wuxilin123@xxxxxxxxx>
>
> ASUS Vivobook S 15 is a laptop based on the Qualcomm Snapdragon X Elite
> SoC (X1E78100).
>
> Add the device tree for the laptop with support for the following features:
>
> - CPU frequency scaling up to 3.4GHz
> - NVMe storage on PCIe 6a (capable of Gen4x4, currently limited to Gen4x2)
> - Keyboard and touchpad
> - WCN7850 Wi-Fi
> - Two Type-C ports on the left side (USB3 only in one orientation)
> - internal eDP display
> - ADSP and CDSP remoteprocs
>
> Further details could be found in the cover letter.
>
> Signed-off-by: Xilin Wu <wuxilin123@xxxxxxxxx>
> ---
[...]
> + pmic-glink {
> + compatible = "qcom,x1e80100-pmic-glink",
> + "qcom,sm8550-pmic-glink",
> + "qcom,pmic-glink";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
> + <&tlmm 123 GPIO_ACTIVE_HIGH>;
#address-/size-cells usually go at the end
> +
> + connector@0 {
Could you add a comment detailing which port is which (like in x1e80100-crd.dts)?
> + pinctrl-names = "default";
> + pinctrl-0 = <&nvme_reg_en>;
property-n
property-names
[...]
> +
> + ports {
> + port@1 {
> + reg = <1>;
Please separate properties with subnodes with a newline
[...]
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie6a_default>;
property-n
property-names
Looks good otherwise!
Konrad
