> Its not clear to me though if the "2500basex" mentioned here supports > any in-band signalling from a Qualcomm SoC POV (not just the Aquantia > phy its attached to, but in general). So maybe in that case its not a > concern? True 2500BaseX does have inband signalling, for the results of pause negotiation. However, in this case, this is not true 2500BaseX, but a hacked SGMII overclocked to 2.5GHz. There is no inband signalling, because SGMII signalling makes no sense when over clocked. So out of band signalling will be used. My understanding is that both ends of this link are not using true 2500BaseX, and this Qualcomm SoC is incapable of true 2500BaseX. So we don't need to worry about it in the Qualcomm glue code. However, what these patches should not block is some other vendors SoC with true 2500BaseX from working correctly. Andrew