On 4/7/2016 12:06 PM, Bjorn Helgaas wrote: >> __release_pci_root_info function if the region type is IO. > I don't know what "removing a slot" means. You're changing > pci_root.c, so I assume this is really an ACPI host bridge removal? > Correct, I'm removing the host bridge. > The release should correspond to a mapping, and the changelog should > point out where that mapping happens so we can see the symmetry. > I apologize. This is based on Tomasz's v5 patch here. https://github.com/semihalf-nowicki-tomasz/linux/blob/pci-acpi-v5/drivers/acpi/pci_root.c > You say this is undoing the effect of pci_remap_iospace(), but that's > only called by native drivers and the generic (OF) driver, not by > pci_root.c. See the ACPI root bridge driver above. > > Please combine this with the previous patch so we have the new > function and its use in the same patch. > I can do that. I was trying to keep the reviews as small as possible. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html