On Wed, Jun 26, 2024 at 10:25:37AM +0800, Jie Gan wrote:
> The coresight_disable_source_sysfs function should verify the
> mode of the coresight device before disabling the source.
> However, the mode for the dummy source device is always set to
> CS_MODE_DISABLED, resulting in the check consistently failing.
> As a result, dummy source cannot be properly disabled.
>
> Configure CS_MODE_SYSFS/CS_MODE_PERF during the enablement.
> Configure CS_MODE_DISABLED during the disablement.
>
> Fixes: 9d3ba0b6c056 ("Coresight: Add coresight dummy driver")
> Signed-off-by: Jie Gan <quic_jiegan@xxxxxxxxxxx>
> ---
> drivers/hwtracing/coresight/coresight-dummy.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-dummy.c b/drivers/hwtracing/coresight/coresight-dummy.c
> index ac70c0b491be..dab389a5507c 100644
> --- a/drivers/hwtracing/coresight/coresight-dummy.c
> +++ b/drivers/hwtracing/coresight/coresight-dummy.c
> @@ -23,6 +23,9 @@ DEFINE_CORESIGHT_DEVLIST(sink_devs, "dummy_sink");
> static int dummy_source_enable(struct coresight_device *csdev,
> struct perf_event *event, enum cs_mode mode)
> {
> + if (!coresight_take_mode(csdev, mode))
> + return -EBUSY;
> +
> dev_dbg(csdev->dev.parent, "Dummy source enabled\n");
>
> return 0;
> @@ -31,6 +34,7 @@ static int dummy_source_enable(struct coresight_device *csdev,
> static void dummy_source_disable(struct coresight_device *csdev,
> struct perf_event *event)
> {
> + coresight_set_mode(csdev, CS_MODE_DISABLED);
> dev_dbg(csdev->dev.parent, "Dummy source disabled\n");
> }
>
> --
> 2.34.1
>
Please ignore this patch. This patch should be included by an independent email.
I will correct it.
Thanks,
Jie
>
