On Tue, 25 Jun 2024 at 15:57, Georgi Djakov <djakov@xxxxxxxxxx> wrote: > > On 25.06.24 10:50, Dmitry Baryshkov wrote: > > On Fri, 14 Jun 2024 at 21:05, Dmitry Baryshkov > > <dmitry.baryshkov@xxxxxxxxxx> wrote: > >> > >> On Wed, 17 Apr 2024 at 16:39, Georgi Djakov <quic_c_gdjako@xxxxxxxxxxx> wrote: > >>> > >>> Add the device-tree nodes for the TBUs (translation buffer units) that > >>> are present on the sdm845 platforms. The TBUs can be used debug the > >>> kernel and provide additional information when a context faults occur. > >>> > >>> Describe the all registers, clocks, interconnects and power-domain > >>> resources that are needed for each of the TBUs. > >>> > >>> Signed-off-by: Georgi Djakov <quic_c_gdjako@xxxxxxxxxxx> > >> > >> This patch now prevents interconnect drivers from hitting the sync > >> state on SDM845. > >> The TBU driver is enabled only when the ARM_SMMU_QCOM_DEBUG is > >> enabled, which is not a typical case on a normal system: > > > > Georgi, before I start acting like a bull in a china shop and sending > > reverts, any update from your side? > > Hi Dmitry! > Thanks for the report! We can easily add status = "disabled" to the DT > nodes, but please give me some time to take a look what would be the best > way to handle this, as i was out last week and now i am still catching up. I think the simplest thing would be to move the TBU driver to the arm-qcom-smmu.c instead of having it in the -debug.c > > BR, > Georgi > > > > >> > >> [ 26.209151] qnoc-sdm845 1500000.interconnect: sync_state() pending > >> due to 150c5000.tbu > >> [ 26.217228] qnoc-sdm845 1620000.interconnect: sync_state() pending > >> due to 150c5000.tbu > >> [ 26.229926] qnoc-sdm845 1500000.interconnect: sync_state() pending > >> due to 150c9000.tbu > >> [ 26.238008] qnoc-sdm845 1620000.interconnect: sync_state() pending > >> due to 150c9000.tbu > >> [ 26.249068] qnoc-sdm845 1740000.interconnect: sync_state() pending > >> due to 150cd000.tbu > >> [ 26.257127] qnoc-sdm845 1740000.interconnect: sync_state() pending > >> due to 150d1000.tbu > >> [ 26.265159] qnoc-sdm845 1740000.interconnect: sync_state() pending > >> due to 150d5000.tbu > >> [ 26.273189] qnoc-sdm845 1500000.interconnect: sync_state() pending > >> due to 150d9000.tbu > >> [ 26.281206] qnoc-sdm845 1620000.interconnect: sync_state() pending > >> due to 150d9000.tbu > >> [ 26.289203] qnoc-sdm845 1500000.interconnect: sync_state() pending > >> due to 150dd000.tbu > >> [ 26.297196] qnoc-sdm845 1620000.interconnect: sync_state() pending > >> due to 150dd000.tbu > >> [ 26.305201] qnoc-sdm845 1500000.interconnect: sync_state() pending > >> due to 150e1000.tbu > >> [ 26.313207] qnoc-sdm845 1620000.interconnect: sync_state() pending > >> due to 150e1000.tbu > > > -- With best wishes Dmitry
