On Mon, Jun 24, 2024 at 04:06:24PM GMT, Konrad Dybcio wrote:
>
>
> On 6/23/24 21:34, Krzysztof Kozlowski wrote:
> > Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used
> > amd,imageon compatible for the SM8150 just to enable headless mode due
> > to missing display controller nodes. This work-around was later
> > narrowed to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts:
> > qcom: sm8150: Don't start Adreno in headless mode").
> >
> > This was not a correct solution, because the Qualcomm SM8150 SoC does
> > not have an AMD GPU and the SM8150 MTP board does not have magically
> > different GPU than SM8150 SoC.
> >
> > Rely on board compatible to achieve the same in a Devicetree-correct
> > way.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > ---
>
> Let's just forget this exists, this was a hack from the start and not
> a very necessary one given display bringup followed soon..
>
> This should be handled by a module parameter if anything
We discussed having a modparam for separate KMS and GPU msm drivers, but
I've never implemented it.
--
With best wishes
Dmitry
