On 23/06/2024 14:28, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 13:06, Akhil P Oommen wrote: >>> Add the necessary dt nodes for gpu support in X1E80100. >>> >>> Signed-off-by: Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx> >>> --- >>> + gmu: gmu@3d6a000 { >>> + compatible = "qcom,adreno-gmu-x185.1", "qcom,adreno-gmu"; >>> + reg = <0x0 0x03d50000 0x0 0x10000>, >>> + <0x0 0x03d6a000 0x0 0x35000>, >>> + <0x0 0x0b280000 0x0 0x10000>; >>> + reg-names = "rscc", "gmu", "gmu_pdc"; >> >> Really, please start testing your patches. Your internal instructions >> tells you to do that, so please follow it carefully. Don't use the >> community as the tool, because you do not want to run checks and >> investigate results. > > This was obviously tested before (and retested now) and everything works. I am > confused about what you meant. Could you please elaborate a bit? The device > and the compilation/test setup is new for me, so I am wondering if I > made any silly mistake! Eh, your DTS is not correct, but this could not be pointed out by tests, because the binding does not work. :( I'll fix up the binding and then please test on top of my patch (see your internal guideline about necessary tests before sending any binding or DTS patch). Best regards, Krzysztof