On Thu, 20 Jun 2024 at 20:32, Rob Clark <robdclark@xxxxxxxxx> wrote: > > On Thu, May 30, 2024 at 2:48 AM Marc Gonzalez <mgonzalez@xxxxxxxxxx> wrote: > > > > On 16/05/2024 10:43, Marijn Suijten wrote: > > > > > On 2024-05-15 17:09:02, Marc Gonzalez wrote: > > > > > >> When create_address_space() fails (e.g. when smmu node is disabled) > > Note that smmu support is going to become a hard dependency with the > drm_gpuvm/VM_BIND conversion.. which I think means we should never get > far enough to hit this error path.. Does that mean that we will lose GPU support on MSM8974? > > BR, > -R > > > >> msm_gpu_init() silently fails: > > >> > > >> msm_dpu c901000.display-controller: failed to load adreno gpu > > >> msm_dpu c901000.display-controller: failed to bind 5000000.gpu (ops a3xx_ops): -19 > > >> > > >> Log create_address_space() failure. > > >> > > >> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> > > > > > > Thanks! > > > > > > Suggested-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > > > > > And, after checking the below: > > > > > > Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > > -- With best wishes Dmitry
