Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 30, 2016 at 05:23:12PM +0300, Georgi Djakov wrote:

> +	} else if (_regulator_is_enabled(rdev) &&
> +		   rdev->desc->ops->set_voltage_time_sel &&
> +		   rdev->desc->ops->get_voltage) {
> +		int uV = rdev->desc->ops->get_voltage(rdev);
> +
> +		if (uV > 0) {
> +			old_selector = regulator_map_voltage(rdev, uV, uV);
> +			if (old_selector < 0)
> +				return old_selector;
> +		}

If a driver is using selectors it should use selectors uninformly, it
should not mix and match selector and raw voltage interfaces.  If we
the set and get operations are not symmetric I'd expect we're going to
run into problems sooner rather than later.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux