On 18/06/2024 15:59, Dzmitry Sankouski wrote: > maxim,max77705 is MAX77705 pmic binding part > > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx> > --- > .../devicetree/bindings/mfd/maxim,max77705.yaml | 112 +++++++++++++++++++++ Your patch order is totally messed. Not tested by automation. Only limited review follows. > MAINTAINERS | 1 + > 2 files changed, 113 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > new file mode 100644 > index 000000000000..b54408e3d792 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX77705 Companion Power Management IC and USB Type-C interface IC > + > +maintainers: > + - Dzmitry Sankouski <dsankouski@xxxxxxxxx> > + > +description: | > + This is a part of device tree bindings for Maxim MAX77705 multi functional device. > + > + The Maxim MAX77705 is a Companion Power Management and Type-C interface IC which > + includes charger, fuelgauge, LED, haptic motor driver and Type-C management IC. > + > +properties: > + compatible: > + const: maxim,max77705 > + > + reg: > + description: > + I2C device address. Drop description, obvious. > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-names: > + description: > + MAX77705 shared irq. > + items: > + - const: max77705_irq Drop entire property, not really useful. > + > + charger: > + $ref: /schemas/power/supply/maxim,max77705-charger.yaml > + > + fuelgauge: > + $ref: /schemas/power/supply/maxim,max77705-fg.yaml > + > + haptic: > + $ref: /schemas/input/maxim,max77705.yaml > + > + leds: > + $ref: /schemas/leds/maxim,max77705.yaml > + > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/leds/common.h> > + > + i2c14 { i2c > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@66 { > + compatible = "maxim,max77705"; > + reg = <0x66>; Totally messed indentation. Fix your code. Best regards, Krzysztof
