On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add binding for the Samsung s6e3ha8 panel found in the Samsung S9. > > Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx> > --- > .../bindings/display/panel/samsung,s6e3ha8.yaml | 76 ++++++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 81 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml > new file mode 100644 > index 000000000000..9d7d747264dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,s6e3ha8.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung s6e3ha8 AMOLED DSI panel > + > +description: The s6e3ha8 is a 1440x2960 DPI display panel from Samsung Mobile > + Displays (SMD). > + > +maintainers: > + - Dzmitry Sankouski <dsankouski@xxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,s6e3ha8 > + > + reg: > + maxItems: 1 > + > + reset-gpios: > + description: reset gpio Pointless description. I think this can be reset-gpios: true, because gpio-consumer-common provides constrain. > + > + port: true > + > + vdd3-supply: > + description: VDD regulator > + > + vci-supply: > + description: VCI regulator > + > + vddr-supply: > + description: VDDR regulator > + > +required: > + - compatible > + - reset-gpios > + - vdd3-supply > + - vddr-supply > + - vci-supply > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + compatible = "samsung,s6e3ha8"; > + reg = <0>; Messed indentation. Keep consistent one. Best regards, Krzysztof
