On 5/30/24 15:57, Alexander Reimelt wrote:
To make it easier for downstream projects and avoid duplication of work.
Makes the device bootable and enables all buttons, hall sensor, eMMC and SD-Card.
Signed-off-by: Alexander Reimelt <alexander.reimelt@xxxxxxxxx>
---
[...]
+ chosen {};
There's already one in msm8994.dtsi
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ spin-table@6000000 {
+ reg = <0 0x6000000 0 0x1000>;
Please pad the non-zero size part to 8 hex digits and use 0x0 instead
of 0 consistently
+ no-map;
+ };
+
+ ramoops@ff00000 {
+ compatible = "ramoops";
+ reg = <0x0 0xff00000 0x0 0x100000>;
+ console-size = <0x20000>;
+ pmsg-size = <0x20000>;
+ record-size = <0x10000>;
+ ecc-size = <0x10>;
+ };
+
+ cont_splash_mem: fb@3400000 {
+ compatible = "framebuffer";
Doesn't seem like a documented compatible, you're probably looking for
"simple-framebuffer", see:
Documentation/devicetree/bindings/display/simple-framebuffer.yaml
The rest looks OK!
Konrad
