Re: [PATCH v3 33/41] iio: magnetometer: ak8974: make use of regmap_set_bits()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>
Subject: Re: [PATCH v3 33/41] iio: magnetometer: ak8974: make use of regmap_set_bits()
From: Linus Walleij <linus.walleij@xxxxxxxxxx>
Date: Tue, 18 Jun 2024 13:11:52 +0200
Cc: Jonathan Cameron <jic23@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx>, Michael Hennerich <Michael.Hennerich@xxxxxxxxxx>, Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Ray Jui <rjui@xxxxxxxxxxxx>, Scott Branden <sbranden@xxxxxxxxxxxx>, Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxx>, Jerome Brunet <jbrunet@xxxxxxxxxxxx>, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>, Saravanan Sekar <sravanhome@xxxxxxxxx>, Orson Zhai <orsonzhai@xxxxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, Chunyan Zhang <zhang.lyra@xxxxxxxxx>, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, Nuno Sá <nuno.sa@xxxxxxxxxx>, Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx>, Crt Mori <cmo@xxxxxxxxxxx>, linux-iio@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, imx@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
In-reply-to: <20240617-review-v3-33-88d1338c4cca@baylibre.com>
References: <20240617-review-v3-0-88d1338c4cca@baylibre.com> <20240617-review-v3-33-88d1338c4cca@baylibre.com>

On Mon, Jun 17, 2024 at 3:50 PM Trevor Gamblin <tgamblin@xxxxxxxxxxxx> wrote:

> Instead of using regmap_update_bits() and passing the mask twice, use
> regmap_set_bits().
>
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> Signed-off-by: Trevor Gamblin <tgamblin@xxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij

References:
- [PATCH v3 00/41] iio: simplify with regmap_set_bits(), regmap_clear_bits()
  - From: Trevor Gamblin
- [PATCH v3 33/41] iio: magnetometer: ak8974: make use of regmap_set_bits()
  - From: Trevor Gamblin

Prev by Date: Re: [PATCH v3 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog
Next by Date: Re: [PATCH v1 1/3] dt-bindings: arm: Add binding document for Coresight Slave Register device.
Previous by thread: [PATCH v3 33/41] iio: magnetometer: ak8974: make use of regmap_set_bits()
Next by thread: [PATCH v3 34/41] iio: magnetometer: mmc35240: make use of regmap_set_bits()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]