Re: [PATCH 2/4] soc: qcom: icc-bwmon: Allow for interrupts to be shared across instances

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/4/24 12:16, Krzysztof Kozlowski wrote:
On 04/06/2024 03:11, Sibi Sankar wrote:
The multiple BWMONv4 instances available on the X1E80100 SoC use the
same interrupt number. Mark them are shared to allow for re-use across
instances.

Hey Krzysztof,

Thanks for taking time to review the series :)


Would be nice if you also mention you checked that it is safe to have
both devm and shared interrupts (so you investigated possibility of race
on exit path).

I didn't see any problems with devm being used with SHARED when I posted
it out. After your review comments I went back again to vett the exit
path for races and ran into an pre-existing splat [1] but the bwmon
instances work as expected on module removal/re-insertion.

[1] - https://lore.kernel.org/lkml/20240613164506.982068-1-quic_sibis@xxxxxxxxxxx/

-Sibi


Best regards,
Krzysztof





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux