On Wed, 12 Jun 2024 at 16:20, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, Jun 12, 2024 at 09:19:35AM +0300, Danila Tikhonov wrote: > > On 6/12/24 03:34, Rob Herring (Arm) wrote: > > > On Wed, 12 Jun 2024 01:37:40 +0300, Danila Tikhonov wrote: > > > > Document the MDSS hardware found on the Qualcomm SM7150 platform. > > > > > > > > Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx> > > > > --- > > > > .../display/msm/qcom,sm7150-mdss.yaml | 460 ++++++++++++++++++ > > > > 1 file changed, 460 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dts:25:18: fatal error: dt-bindings/clock/qcom,sm7150-dispcc.h: No such file or directory > > > 25 | #include <dt-bindings/clock/qcom,sm7150-dispcc.h> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > compilation terminated. > > > make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/display/msm/qcom,sm7150-mdss.example.dtb] Error 1 > > > make[2]: *** Waiting for unfinished jobs.... > > > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2 > > > make: *** [Makefile:240: __sub-make] Error 2 > > > > > > doc reference errors (make refcheckdocs): > > > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240611223743.113223-2-danila@xxxxxxxxxxx > > > > > > The base for the series is generally the latest rc1. A different dependency > > > should be noted in *this* patch. > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > > > Please check and re-submit after running the above command yourself. Note > > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > > your schema. However, it must be unset to test all examples with your schema. > > > > > > > Yes, this happened because I forgot to add note (same for both dtbindings): > > Depends on commit ca3a91063acc (dt-bindings: clock: qcom: Add SM7150 DISPCC > > clocks) > > So then this can't be merged as I imagine that is in a different tree. > Maybe you want to not use the header for the example. Danila, please resend using invented clocks like <&dispcc_whatever_ahb_mdss_clk> instead. I don't want for it to be delayed further. -- With best wishes Dmitry
