Re: [PATCH 10/12] ARM: dts: dragonboard-600c: Add on board leds support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 23, 2016 at 8:48 PM, Srinivas Kandagatla
<srinivas.kandagatla@xxxxxxxxxx> wrote:
> +                       led@1 {
> +                               label = "dragonboard-600c:green:user1";
> +                               gpios = <&tlmm_pinmux 3 GPIO_ACTIVE_HIGH>;
> +                               linux,default-trigger = "heartbeat";
> +                               default-state = "off";
> +                       };
> +
> +                       led@2 {
> +                               label = "dragonboard-600c:green:user2";
> +                               gpios = <&tlmm_pinmux 7 GPIO_ACTIVE_HIGH>;
> +                               linux,default-trigger = "mmc0";
> +                               default-state = "off";
> +                       };
> +
> +                       led@3 {
> +                               label = "dragonboard-600c:green:user3";
> +                               gpios = <&tlmm_pinmux 10 GPIO_ACTIVE_HIGH>;
> +                               linux,default-trigger = "mmc1";
> +                               default-state = "off";
> +                       };
> +
> +                       led@4 {
> +                               label = "apq8016-sbc:green:user4";

typo ^^

> +                               gpios = <&tlmm_pinmux 11 GPIO_ACTIVE_HIGH>;
> +                               linux,default-trigger = "none";
> +                               default-state = "off";
> +                       };

also, if i read the 96boards specs correctly, the LED are labeled
3-2-1-0 , if you look at the board with the LEDs on the bottom. With
this DT config, you end up with 0-1-2-3 instead.

also, they should be labeled 0 to 3, not 1 to 4.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux