On 06/06/2024 15:03, srinivas.kandagatla@xxxxxxxxxx wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > > Add device tree binding Documentation details for Qualcomm SM4250 LPASS > LPI(Low power Island) pinctrl device. ... > + > +description: > + Top Level Mode Multiplexer pin controller in the Low Power Audio SubSystem > + (LPASS) Low Power Island (LPI) of Qualcomm SM4250 SoC. > + > +properties: > + compatible: > + const: qcom,sm4250-lpass-lpi-pinctrl > + > + reg: > + maxItems: 2 Please use recent bindings as starting work or template, e.g. sm8550 or sm8650. IOW, you need to list the items. > + > + clocks: > + items: > + - description: LPASS Audio voting clock > + > + clock-names: > + items: > + - const: audio > + > +patternProperties: > + "-state$": > + oneOf: > + - $ref: "#/$defs/qcom-sm4250-lpass-state" > + - patternProperties: > + "-pins$": > + $ref: "#/$defs/qcom-sm4250-lpass-state" > + additionalProperties: false > + > +$defs: > + qcom-sm4250-lpass-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: qcom,lpass-lpi-common.yaml#/$defs/qcom-tlmm-state > + unevaluatedProperties: false > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + oneOf: No need for oneOf. And then directly "pattern" without leading hyphen. > + - pattern: "^gpio([0-9]|1[0-8])$" > + minItems: 1 > + maxItems: 19 > + > + function: > + enum: [ gpio, dmic01_clk, dmic01_data, dmic23_clk, dmic23_data, > + dmic4_clk, dmic4_data, ext_mclk0_a, ext_mclk0_b, ext_mclk1_a, > + ext_mclk1_b, ext_mclk1_c, i2s1_clk, i2s1_data, i2s1_ws, > + i2s2_clk, i2s2_data, i2s2_ws, i2s3_clk, i2s3_data, i2s3_ws, > + qua_mi2s_data, qua_mi2s_sclk, qua_mi2s_ws, slim_clk, slim_data, > + swr_rx_clk, swr_rx_data, swr_tx_clk, swr_tx_data, swr_wsa_clk, > + swr_wsa_data ] > + description: > + Specify the alternative function to be configured for the specified > + pins. > + > +allOf: > + - $ref: qcom,lpass-lpi-common.yaml# > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + Best regards, Krzysztof
