On 6.06.2024 10:16 AM, Neil Armstrong wrote:
> With the SM8650-HDK, a Display Card kit can be connected to provide
> a VTDR6130 display with Goodix Berlin Touch controller.
>
> In order to route the DSI lanes to the connector for the Display
> Card kit, a switch must be changed on the board.
>
> The HDMI nodes are disabled since the DSI lanes are shared with
> the DSI to HDMI transceiver.
>
> Add support for this card as an overlay and apply it it at
> build-time to the sm8650-hdk dtb.
>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> Tested-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
[...]
> +
/* Disable HDMI bridge related nodes (mutually exclusive with the display card) */
> +&i2c6 {
> + status = "disabled";
> +};
> +
> +<9611_1v2 {
> + status = "disabled";
> +};
> +
> +<9611_3v3 {
> + status = "disabled";
> +};
> +
> +&vreg_bob_3v3 {
> + status = "disabled";
> +};
> +
> +<9611_codec {
> + status = "disabled";
> +};
> +
> +&mdss_dsi0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "visionox,vtdr6130";
> + reg = <0>;
> +
> + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
> +
> + vddio-supply = <&vreg_l12b_1p8>;
> + vci-supply = <&vreg_l13b_3p0>;
> + vdd-supply = <&vreg_l11b_1p2>;
> +
> + pinctrl-0 = <&disp0_reset_n_active>, <&mdp_vsync>;
> + pinctrl-1 = <&disp0_reset_n_suspend>, <&mdp_vsync>;
> + pinctrl-names = "default", "sleep";
> +
> + port {
> + panel0_in: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> + };
> +
> + /*
> + * DTC requires to have both endpoints when compiling the overlay
> + * and also requires the #address/size-cells + reg properties
> + */
[...]
> + /* DTC requires the #address/size-cells to compile DTBO */
I think we can leave out such comments, if somebody tries to "clean it up",
dtc will scream
with that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Konrad
