On 22.05.2024 3:08 PM, Bartosz Golaszewski wrote: > On Wed, May 22, 2024 at 3:06 PM <neil.armstrong@xxxxxxxxxx> wrote: >> >> On 22/05/2024 15:04, Bartosz Golaszewski wrote: >>> On Wed, May 22, 2024 at 2:42 PM <neil.armstrong@xxxxxxxxxx> wrote: >>>> >>>> On 22/05/2024 14:08, Bartosz Golaszewski wrote: >>>>> From: Tengfei Fan <quic_tengfan@xxxxxxxxxxx> >>>>> >>>>> Document the compatibles for the components used to boot the ADSP, CDSP0, >>>>> CDSP1, GPDSP0 and GPDSP1 on the SA8775p SoC. >>>>> >>>>> Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx> >>>>> Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >>>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> >>>>> --- >>>>> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 76 +++++++++++++++++++++- >>>>> 1 file changed, 75 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>> index 73fda7565cd1..9d3a862c39e1 100644 >>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>> @@ -16,6 +16,11 @@ description: >>>>> properties: >>>>> compatible: >>>>> enum: >>>>> + - qcom,sa8775p-adsp-pas >>>>> + - qcom,sa8775p-cdsp0-pas >>>>> + - qcom,sa8775p-cdsp1-pas >>>>> + - qcom,sa8775p-gpdsp0-pas >>>>> + - qcom,sa8775p-gpdsp1-pas >>>>> - qcom,sm8550-adsp-pas >>>>> - qcom,sm8550-cdsp-pas >>>>> - qcom,sm8550-mpss-pas >>>>> @@ -44,12 +49,13 @@ properties: >>>>> >>>>> firmware-name: >>>>> $ref: /schemas/types.yaml#/definitions/string-array >>>>> + minItems: 1 >>>> >>>> This will allow a single firmware name for all compatible, >>>> which is wrong >>>> >>> >>> So increasing the limit from the default under allOf doesn't seem to >>> work, should I instead keep this and make the lower limit stricter for >>> all other models? >> >> Yes add minItems in all the allOf:if: and add the missing allOf:if: for >> the new compatibles to set the minItems, same for memory-region. >> >> Or you may simply spin off a new yaml, this one is getting quite large. >> > > Yeah, maybe that's a better idea. + if you get rid of the 0/1 in "nsp0/nsp1" you save a couple more lines Konrad
