Are there any comments for me regarding the patch ? Please let me know On Sun, Apr 7, 2024 at 12:53 PM Prabhav Kumar Vaish <pvkumar5749404@xxxxxxxxx> wrote: > > Use automated cleanup to replace of_node_put() in qcom_smem_resolve_mem(). > > Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404@xxxxxxxxx> > --- > drivers/soc/qcom/smem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index 7191fa0c087f..ad1cf8dcc6ec 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -1032,18 +1032,16 @@ static int qcom_smem_resolve_mem(struct qcom_smem *smem, const char *name, > struct smem_region *region) > { > struct device *dev = smem->dev; > - struct device_node *np; > struct resource r; > int ret; > + struct device_node *np __free(device_node) = of_parse_phandle(dev->of_node, name, 0); > > - np = of_parse_phandle(dev->of_node, name, 0); > if (!np) { > dev_err(dev, "No %s specified\n", name); > return -EINVAL; > } > > ret = of_address_to_resource(np, 0, &r); > - of_node_put(np); > if (ret) > return ret; > > -- > 2.34.1 >