On 5/11/2024 1:18 AM, Bryan O'Donoghue wrote: > On 11/04/2024 13:45, Gjorgji Rosikopulos wrote: >> + .type = CAMSS_SUBDEV_TYPE_CSIPHY, > > As Matti pointed out to me on IRC, the .type value here isn't populated > in the rest of the 8280xp resources. > > I completely missed that but, then again this appears to be a dead field > in this series so it makes no difference if it is populated. > > I realise it is probably of use in code you _haven't_ yet published but, > for now I think we should drop this field, since its dead code. Yes that is correct i miss that as well. > > I'll send a fixup patch for this, I don't think there's a need for you > to send the whole series again. Thank you for this. ~Gjorgji > > --- > bod