On 09/05/2024 00:09, Stephen Boyd wrote: > Quoting Johan Hovold (2024-05-07 08:23:04) >> On Tue, May 07, 2024 at 08:43:08AM +0200, Krzysztof Kozlowski wrote: >>>> - >>>> maxItems: 1 >>>> >>>> interrupts: >>>> maxItems: 1 >>>> >>>> - description: Parent interrupt. >>>> - >>>> reset-gpios: >>>> maxItems: 1 >>>> >>>> - "#interrupt-cells": >>>> + vdd_l1_l2-supply: true >>> >>> No underscores in property names. >> >> Indeed. These names come from Qualcomm's v15, but I should have caught >> that. Thanks. > > Drive by comment: we have underscores to match the label on the > datasheet. Not sure that will sway your opinion. Only trying to provide > some background rationale. I know, but if datasheet calls this "yellow_pony_!!!#1l33t-supply" we still won't use datasheet names directly, so s/_/-/. That's also W=2 warning. Best regards, Krzysztof