On Tue, Apr 30, 2024 at 08:45:18PM -0700, Sagar Cheluvegowda wrote:
> Ethernet devices are cache coherent, mark it as such in the dtsi.
> Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
> Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
>
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@xxxxxxxxxxx>
Nit: Fixes: and Signed-off-by: should be grouped together.. i.e.:
Ethernet devices are cache coherent, mark it as such in the dtsi.
Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
Signed-off-by: Sagar Cheluvegowda <quic_scheluve@xxxxxxxxxxx>
> ---
> Changes in v2:
> Remove internal change-id from commit message
> - Link to v1: https://lore.kernel.org/r/20240425-mark_ethernet_devices_dma_coherent-v1-1-ad0755044e26@xxxxxxxxxxx
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 231cea1f0fa8..5ab4ca978837 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -2504,6 +2504,7 @@ ethernet1: ethernet@23000000 {
> phy-names = "serdes";
>
> iommus = <&apps_smmu 0x140 0xf>;
> + dma-coherent;
>
> snps,tso;
> snps,pbl = <32>;
> @@ -2538,6 +2539,7 @@ ethernet0: ethernet@23040000 {
> phy-names = "serdes";
>
> iommus = <&apps_smmu 0x120 0xf>;
> + dma-coherent;
Does the schema need updating then?
(dtb-checker) ahalaney@x1gen2nano ~/git/linux-next (git)-[b4970433daf5] % make CC=clang ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y DT_SCHEMA_FILES=/net/qcom,ethqos.yaml qcom/sa8775p-ride.dtb
UPD include/config/kernel.release
DTC_CHK arch/arm64/boot/dts/qcom/sa8775p-ride.dtb
/home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: ethernet@23000000: Unevaluated properties are not allowed ('dma-coherent' was unexpected)
from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#
/home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: ethernet@23040000: Unevaluated properties are not allowed ('dma-coherent' was unexpected)
from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#
You can use eb15bd5c2a69 ("dt-bindings: dmaengine: qcom: gpi: Allow dma-coherent")
for inspiration for crafting that patch and adding it into the beginning
of this series.
>
> snps,tso;
> snps,pbl = <32>;
>
> ---
> base-commit: a93289b830ce783955b22fbe5d1274a464c05acf
> change-id: 20240425-mark_ethernet_devices_dma_coherent-6c6154b84165
It seems you're using b4 (yay! good choice). I noticed the To/Cc list
here seems small. b4 prep --auto-to-cc should basically use
get_maintainers.pl and include the relevant folks. You can add on to it
from there with b4 prep --edit-cover. Typically if someone gives you a comment
on a patch its a good idea to Cc them on the next version (in case they weren't
on the prior).
>
> Best regards,
> --
> Sagar Cheluvegowda <quic_scheluve@xxxxxxxxxxx>
>
>
