On 24.04.2024 5:29 PM, Xilin Wu via B4 Relay wrote:
> From: Xilin Wu <wuxilin123@xxxxxxxxx>
>
> AYN Odin 2 is a gaming handheld based on QCS8550, which is derived
> from SM8550 but without modem RF system.
>
> This commit brings support for:
> * Remoteprocs
> * UFS storage
> * SD Card
> * Type-C with USB3 10Gbps and DisplayPort (4-lane requires a pending
> patch)
> * PCIe0 (Wi-Fi requires the pending pwrseq series)
> * Bluetooth
> * Regulators
> * Integrated fan with automatic speed control based on CPU temperature
> * Power and volume keys
> * M1, M2 buttons
> * HDMI output up to 1080p 60hz
> * four groups of RGB lights
> * GPU
> * Internal DSI display with touchscreen
>
> Signed-off-by: Xilin Wu <wuxilin123@xxxxxxxxx>
> ---
[...]
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pmk8550_pwm 0 860000>;
> + brightness-levels = <1023 0>;
Huh? Is min/max swapped?
> + num-interpolated-steps = <1023>;
> + default-brightness-level = <600>;
> + power-supply = <&vph_pwr>;
> + enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm_backlight_default>;
property-n
property-names
[...]
> + cooling-maps {
> + map0 {
> + trip = <&cpuss0_active0>;
> + cooling-device = <&fan 0 1>;
> + };
Please adda a newline between each subnode
[...]
> + /* Setting regulator-allow-set-load here will crash the device */
??
> + vreg_l17b_2p5: ldo17 {
> + regulator-name = "vreg_l17b_2p5";
> + regulator-min-microvolt = <2504000>;
> + regulator-max-microvolt = <2504000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> + };
> +
[...]
> +
> + backlight = <&backlight>;
> + /* touchscreen and display panel share the same reset gpio! */
> + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
Perhaps you would be interested in drm_panel_follower
[...]
> +
> +&sdhc_2 {
> + cd-gpios = <&pm8550_gpios 12 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_default &sdc2_card_det_n>;
> + pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>;
> + vmmc-supply = <&vreg_l9b_2p9>;
> + vqmmc-supply = <&vreg_l8b_1p8>;
> + bus-width = <4>;
> + no-sdio;
> + no-mmc;
> +
> + /* SDR104 does seem to be working on this device*/
> + /delete-property/ sdhci-caps-mask;
Eeeh.. I'm not sure about this. Maybe it still has some issues that
don't manifest immediately.
[...]
> +&uart15 {
> + status = "okay";
> +
> + /* Gamepad controlled by onboard MCU */
As in, that MCU is connected to 8550 through this UART port?
Konrad
