On Wed, Apr 17, 2024 at 10:05:45PM +0200, Konrad Dybcio wrote: > On 17.04.2024 9:02 AM, Manivannan Sadhasivam wrote: > > There is no need for the device drivers to validate the clocks defined in > > Devicetree. The validation should be performed by the DT schema and the > > drivers should just get all the clocks from DT. Right now the driver > > hardcodes the clock info and validates them against DT which is redundant. > > > > So use devm_clk_bulk_get_all() that just gets all the clocks defined in DT > > and get rid of all static clocks info from the driver. This simplifies the > > driver. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > Even better, you can push the bulk_get_all to a common function so as not > to duplicate it for every gen! > I don't see a benefit in doing so. It is just a function call and using a helper will cause inconsistency with other API usage in this driver. I prefer to keep it as it is. - Mani -- மணிவண்ணன் சதாசிவம்
