On 4/29/24 16:39, Bryan O'Donoghue wrote:
On 29/04/2024 14:45, Marc Gonzalez wrote:
On 27/04/2024 21:34, Bjorn Andersson wrote:
On Thu, 25 Apr 2024 17:07:07 +0200, Marc Gonzalez wrote:
Right now, msm8998 video decoder (venus) is non-functional:
$ time mpv --hwdec=v4l2m2m-copy --vd-lavc-software-fallback=no --vo=null --no-audio --untimed --length=30 --quiet demo-480.webm
(+) Video --vid=1 (*) (vp9 854x480 29.970fps)
Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz)
[ffmpeg/video] vp9_v4l2m2m: output VIDIOC_REQBUFS failed: Connection timed out
[ffmpeg/video] vp9_v4l2m2m: no v4l2 output context's buffers
[ffmpeg/video] vp9_v4l2m2m: can't configure decoder
Could not open codec.
Software decoding fallback is disabled.
Exiting... (Quit)
[...]
Applied, thanks!
[1/1] clk: qcom: mmcc-msm8998: fix venus clock issue
commit: e20ae5ae9f0c843aded4f06f3d1cab7384789e92
Yes!
Going on a tangent.
During my tests, I saw an unrelated error in the boot log:
[ 10.404521] clk: Disabling unused clocks
[ 10.412141] ------------[ cut here ]------------
[ 10.415538] vmem_ahb_clk status stuck at 'on'
We currently don't support VMEM (which is a small SRAM dedicated to venus)
upstream, but venus functions without it (albeit I'd expect it to be
slower or not fully capable without it)
[ 10.415570] WARNING: CPU: 0 PID: 1 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x160/0x178
[ 10.424420] Modules linked in:
[ 10.433586] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc1-00027-g483ea571c987 #70
[ 10.436478] Hardware name: Freebox Delta (DT)
[ 10.444356] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 10.448884] pc : clk_branch_toggle+0x160/0x178
[ 10.455642] lr : clk_branch_toggle+0x160/0x178
[ 10.460154] sp : ffff80008005bc40
[ 10.464574] x29: ffff80008005bc40 x28: 0000000000000000 x27: ffff800082df9070
[ 10.467982] x26: ffff800082d100b0 x25: ffff800082c57cb0 x24: ffff800082b23958
[ 10.475100] x23: 0000000000000000 x22: 0000000000000000 x21: ffff8000833b6208
[ 10.482218] x20: ffff80008072bbec x19: 0000000000000000 x18: ffffffffff00d218
[ 10.489337] x17: ffff800083476aa8 x16: ffff800083476a38 x15: 0000000000000030
[ 10.496454] x14: 0000000000000000 x13: ffff0000f5348000 x12: 000000000000086d
[ 10.503572] x11: 00000000000002cf x10: ffff0000f7f4c368 x9 : ffff0000f5348000
[ 10.510692] x8 : 00000000fff7ffff x7 : ffff0000f7f48000 x6 : 00000000000002cf
[ 10.517809] x5 : 00000000005ffff4 x4 : 40000000fff802cf x3 : 0000000000000000
[ 10.524926] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff000080118000
[ 10.532046] Call trace:
[ 10.539137] clk_branch_toggle+0x160/0x178
[ 10.541402] clk_branch2_disable+0x1c/0x28
[ 10.545569] clk_disable_unused_subtree+0xfc/0x138
[ 10.549652] clk_disable_unused_subtree+0x2c/0x138
[ 10.554427] clk_disable_unused_subtree+0x2c/0x138
[ 10.559201] clk_disable_unused_subtree+0x2c/0x138
[ 10.563975] clk_disable_unused_subtree+0x2c/0x138
[ 10.568749] clk_disable_unused_subtree+0x2c/0x138
[ 10.573525] clk_disable_unused_subtree+0x2c/0x138
[ 10.578298] clk_disable_unused+0x50/0x138
[ 10.583070] do_one_initcall+0x6c/0x1b0
[ 10.587147] kernel_init_freeable+0x1d4/0x2cc
[ 10.590883] kernel_init+0x20/0x1d8
[ 10.595391] ret_from_fork+0x10/0x20
[ 10.598693] ---[ end trace 0000000000000000 ]---
Taking sm8250 as an example the vidoecc ahb clk is a candidate to be always-on.
drivers/clk/qcom/videocc-sm8250.c
qcom_branch_set_clk_en(regmap, 0xe58); /* VIDEO_CC_AHB_CLK */
This is totally unrelated
Konrad
