On 20/04/2024 20:13, Bjorn Andersson wrote: > On Wed, Apr 03, 2024 at 11:44:22AM +0200, Krzysztof Kozlowski wrote: >> Enable the sound machine driver for Qualcomm X1E80100 sound card, used >> on several boards with X1E80100 (e.g. X1E80100 CRD). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> > > I'm completely lost on your strategy for these sound card drivers! > > Why is x1e a separate driver when we're shoehorning in qc*6490 into the > sc8280xp? Because x1e is different. It has 4 speakers. sc8280xp does not have four speakers. > Why does Srini answer me that the compatible should contain the device > name (qcom,qcs6490-rb3gen2-sndcard) while you're at the same time adding > a platform-based compatible for x1e. That's defconfig change... But yeah, probably x1e sound card should be tied to the board model. I prepared and sent the patches much earlier, before qcom,qcs6490-rb3gen2-sndcard came to discussion. For most of the boards I would just go with generic soc compatible. I think I provided rationale qcs6490 discussion. Best regards, Krzysztof
