On Fri, Apr 19, 2024 at 03:08:47PM +0530, Manivannan Sadhasivam wrote: > On Thu, Apr 18, 2024 at 11:12:09AM -0500, Bjorn Helgaas wrote: > > On Thu, Apr 18, 2024 at 05:28:31PM +0530, Manivannan Sadhasivam wrote: > ... > > > - * pci_epc_bme_notify() - Notify the EPF device that the EPC device has received > > > - * the BME event from the Root complex > > > - * @epc: the EPC device that received the BME event > > > + * pci_epc_bus_master_enable_notify() - Notify the EPF device that the EPC > > > + * device has received the Bus Master > > > + * Enable event from the Root complex > > > + * @epc: the EPC device that received the Bus Master Enable event > > > * > > > * Invoke to Notify the EPF device that the EPC device has received the Bus > > > - * Master Enable (BME) event from the Root complex > > > + * Master Enable event from the Root complex > > > > There's no "set Bus Master Enable" transaction that would appear on > > the PCIe link, so I assume "the Bus Master Enable event from the Root > > Complex" is a way of saying something like "host has written the > > Command register to set the Bus Master Enable bit"? > > > > Yes. But looking at it again, it could be reworded as below: > > 'Invoke to notify the EPF device that the EPC device has generated the Bus > Master Enable event due to host setting the Bus Master Enable bit in the > Command register.' Sounds good. Could even s/Invoke to notify/Notify/.
