On Fri, Apr 12, 2024 at 04:18:36PM +0530, Umang Chheda wrote: > Hi Bjorn, > > On 4/9/2024 8:47 PM, Bjorn Andersson wrote: > > On Wed, Apr 03, 2024 at 06:58:39PM +0530, Umang Chheda wrote: > >> The Volume Down & Power buttons are controlled by the PMIC via > >> the PON hardware, and the Volume Up is connected to a PMIC gpio. > >> > >> Enable the necessary hardware and setup the GPIO state for the > >> Volume Up gpio key. > >> > >> Signed-off-by: Umang Chheda <quic_uchheda@xxxxxxxxxxx> > >> --- > > > > I suppose this isn't a "resend" either, so please send me a new version > > of this as well. > > > > I had earlier sent [1] for review, on which I hadn't received any review comments. > I see. If you want reviews on your patches, ask a colleague to invest a few minutes in the patch and send a Reviewed-by or Tested-by. That both Not only will this give you reviews, it will show the community and the maintainer that there's someone out there who's interested in seeing the patch merged. > Hence, I resent this patch again after 2 weeks for review. > Please only resend patches if you strongly believe that necessary recipients didn't receive the patch. Regards, Bjorn
