Hi Bjorn, On 4/9/2024 8:46 PM, Bjorn Andersson wrote: > On Wed, Apr 03, 2024 at 06:59:45PM +0530, Umang Chheda wrote: >> Without explicitly specifying names for the regulators they are named >> based on the DeviceTree node name. This results in multiple regulators >> with the same name, making it impossible to reason debug prints and >> regulator_summary. >> > > Why is this marked "RESEND"? I can only find [1]. I misunderstood Elliot's comment that this patch deserves a Resend instead of a new version (v2) as it was just commit subject change. > > But you received review feedback on that one, which you have addressed, > which means that this is a new version of the patch - as such this > should be "[PATCH v2] ...". > > [1] https://lore.kernel.org/all/20240329122940.3649730-1-quic_uchheda@xxxxxxxxxxx/ > >> Signed-off-by: Umang Chheda <quic_uchheda@xxxxxxxxxxx> >> --- > > And here you can write things that won't be picked up in the git > history, such as the reason for sending the patch, or what changed since > v1. > > > Please look at go/upstream, adopt b4 for preparing your patches, use > --force-revision to send me v3 - where you clarify the changes between > v1 and v2 (this resend). > Thanks for the inputs! > You can specify "Resubmit as v3 to clarify history of patch" or > something like that for the v3 changes. > Ack, I have sent v3 version addressing the above comment. Regards, Umang > > Change itself looks good, thank you. > > Regards, > Bjorn > >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 41 ++++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index f8f8a43f638d..ac6d741868ca 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -195,129 +195,151 @@ regulators-0 { >> vdd-l14-l16-supply = <&vreg_s8b_1p272>; >> >> vreg_s1b_1p872: smps1 { >> + regulator-name = "vreg_s1b_1p872"; >> regulator-min-microvolt = <1840000>; >> regulator-max-microvolt = <2040000>; >> }; >> >> vreg_s2b_0p876: smps2 { >> + regulator-name = "vreg_s2b_0p876"; >> regulator-min-microvolt = <570070>; >> regulator-max-microvolt = <1050000>; >> }; >> >> vreg_s7b_0p972: smps7 { >> + regulator-name = "vreg_s7b_0p972"; >> regulator-min-microvolt = <535000>; >> regulator-max-microvolt = <1120000>; >> }; >> >> vreg_s8b_1p272: smps8 { >> + regulator-name = "vreg_s8b_1p272"; >> regulator-min-microvolt = <1200000>; >> regulator-max-microvolt = <1500000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_RET>; >> }; >> >> vreg_l1b_0p912: ldo1 { >> + regulator-name = "vreg_l1b_0p912"; >> regulator-min-microvolt = <825000>; >> regulator-max-microvolt = <925000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l2b_3p072: ldo2 { >> + regulator-name = "vreg_l2b_3p072"; >> regulator-min-microvolt = <2700000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l3b_0p504: ldo3 { >> + regulator-name = "vreg_l3b_0p504"; >> regulator-min-microvolt = <312000>; >> regulator-max-microvolt = <910000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l4b_0p752: ldo4 { >> + regulator-name = "vreg_l4b_0p752"; >> regulator-min-microvolt = <752000>; >> regulator-max-microvolt = <820000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> reg_l5b_0p752: ldo5 { >> + regulator-name = "reg_l5b_0p752"; >> regulator-min-microvolt = <552000>; >> regulator-max-microvolt = <832000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l6b_1p2: ldo6 { >> + regulator-name = "vreg_l6b_1p2"; >> regulator-min-microvolt = <1140000>; >> regulator-max-microvolt = <1260000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l7b_2p952: ldo7 { >> + regulator-name = "vreg_l7b_2p952"; >> regulator-min-microvolt = <2400000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l8b_0p904: ldo8 { >> + regulator-name = "vreg_l8b_0p904"; >> regulator-min-microvolt = <870000>; >> regulator-max-microvolt = <970000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l9b_1p2: ldo9 { >> + regulator-name = "vreg_l9b_1p2"; >> regulator-min-microvolt = <1200000>; >> regulator-max-microvolt = <1304000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l11b_1p504: ldo11 { >> + regulator-name = "vreg_l11b_1p504"; >> regulator-min-microvolt = <1504000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l12b_0p751: ldo12 { >> + regulator-name = "vreg_l12b_0p751"; >> regulator-min-microvolt = <751000>; >> regulator-max-microvolt = <824000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l13b_0p53: ldo13 { >> + regulator-name = "vreg_l13b_0p53"; >> regulator-min-microvolt = <530000>; >> regulator-max-microvolt = <824000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l14b_1p08: ldo14 { >> + regulator-name = "vreg_l14b_1p08"; >> regulator-min-microvolt = <1080000>; >> regulator-max-microvolt = <1304000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l15b_0p765: ldo15 { >> + regulator-name = "vreg_l15b_0p765"; >> regulator-min-microvolt = <765000>; >> regulator-max-microvolt = <1020000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l16b_1p1: ldo16 { >> + regulator-name = "vreg_l16b_1p1"; >> regulator-min-microvolt = <1100000>; >> regulator-max-microvolt = <1300000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l17b_1p7: ldo17 { >> + regulator-name = "vreg_l17b_1p7"; >> regulator-min-microvolt = <1700000>; >> regulator-max-microvolt = <1900000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l18b_1p8: ldo18 { >> + regulator-name = "vreg_l18b_1p8"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l19b_1p8: ldo19 { >> + regulator-name = "vreg_l19b_1p8"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> @@ -349,109 +371,128 @@ regulators-1 { >> vdd-bob-supply = <&vph_pwr>; >> >> vreg_s1c_2p19: smps1 { >> + regulator-name = "vreg_s1c_2p19"; >> regulator-min-microvolt = <2190000>; >> regulator-max-microvolt = <2210000>; >> }; >> >> vreg_s2c_0p752: smps2 { >> + regulator-name = "vreg_s2c_0p752"; >> regulator-min-microvolt = <750000>; >> regulator-max-microvolt = <800000>; >> }; >> >> vreg_s5c_0p752: smps5 { >> + regulator-name = "vreg_s5c_0p752"; >> regulator-min-microvolt = <465000>; >> regulator-max-microvolt = <1050000>; >> }; >> >> vreg_s7c_0p752: smps7 { >> + regulator-name = "vreg_s7c_0p752"; >> regulator-min-microvolt = <465000>; >> regulator-max-microvolt = <800000>; >> }; >> >> vreg_s9c_1p084: smps9 { >> + regulator-name = "vreg_s9c_1p084"; >> regulator-min-microvolt = <1010000>; >> regulator-max-microvolt = <1170000>; >> }; >> >> vreg_l1c_1p8: ldo1 { >> + regulator-name = "vreg_l1c_1p8"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <1980000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l2c_1p62: ldo2 { >> + regulator-name = "vreg_l2c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <1980000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l3c_2p8: ldo3 { >> + regulator-name = "vreg_l3c_2p8"; >> regulator-min-microvolt = <2800000>; >> regulator-max-microvolt = <3540000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l4c_1p62: ldo4 { >> + regulator-name = "vreg_l4c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <3300000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l5c_1p62: ldo5 { >> + regulator-name = "vreg_l5c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <3300000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l6c_2p96: ldo6 { >> + regulator-name = "vreg_l6c_2p96"; >> regulator-min-microvolt = <1650000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l7c_3p0: ldo7 { >> + regulator-name = "vreg_l7c_3p0"; >> regulator-min-microvolt = <3000000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l8c_1p62: ldo8 { >> + regulator-name = "vreg_l8c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l9c_2p96: ldo9 { >> + regulator-name = "vreg_l9c_2p96"; >> regulator-min-microvolt = <2700000>; >> regulator-max-microvolt = <35440000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l10c_0p88: ldo10 { >> + regulator-name = "vreg_l10c_0p88"; >> regulator-min-microvolt = <720000>; >> regulator-max-microvolt = <1050000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l11c_2p8: ldo11 { >> + regulator-name = "vreg_l11c_2p8"; >> regulator-min-microvolt = <2800000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l12c_1p65: ldo12 { >> + regulator-name = "vreg_l12c_1p65"; >> regulator-min-microvolt = <1650000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_l13c_2p7: ldo13 { >> + regulator-name = "vreg_l13c_2p7"; >> regulator-min-microvolt = <2700000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; >> }; >> >> vreg_bob_3p296: bob { >> + regulator-name = "vreg_bob_3p296"; >> regulator-min-microvolt = <3008000>; >> regulator-max-microvolt = <3960000>; >> }; >> -- >> 2.25.1 >>
