Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/28/2024 7:40 AM, Bjorn Andersson wrote:
From: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>

The dp_audio read and write operations uses members in struct dp_catalog
for passing arguments and return values. This adds unnecessary
complexity to the implementation, as it turns out after detangling the
logic that no state is actually held in these variables.

Clean this up by using function arguments and return values for passing
the data.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>
---
  drivers/gpu/drm/msm/dp/dp_audio.c   | 20 +++++--------------
  drivers/gpu/drm/msm/dp/dp_catalog.c | 39 +++++++++++++------------------------
  drivers/gpu/drm/msm/dp/dp_catalog.h | 18 +++++++++--------
  3 files changed, 28 insertions(+), 49 deletions(-)


One quick question, was DP audio re-tested after this patch?




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux