On Thu, 04 Apr 2024 17:01:03 -0700, Stephen Boyd wrote: > The register base that was used to write to the QSERDES_DP_PHY_MODE > register was 'dp_dp_phy' before commit 815891eee668 ("phy: > qcom-qmp-combo: Introduce orientation variable"). There isn't any > explanation in the commit why this is changed, so I suspect it was an > oversight or happened while being extracted from some other series. > Oddly the value being 0x4c or 0x5c doesn't seem to matter for me, so I > suspect this is dead code, but that can be fixed in another patch. It's > not good to write to the wrong register space, and maybe some other > version of this phy relies on this. > > [...] Applied, thanks! [1/1] phy: qcom: qmp-combo: Fix register base for QSERDES_DP_PHY_MODE commit: ee13e1f3c72b9464a4d73017c060ab503eed653a Best regards, -- ~Vinod