Hi Konrad, kernel test robot noticed the following build warnings: [auto build test WARNING on 2b3d5988ae2cb5cd945ddbc653f0a71706231fdd] url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/soc-qcom-Move-some-socinfo-defines-to-the-header-expand-them/20240405-164231 base: 2b3d5988ae2cb5cd945ddbc653f0a71706231fdd patch link: https://lore.kernel.org/r/20240405-topic-smem_speedbin-v1-2-ce2b864251b1%40linaro.org patch subject: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters config: arm-defconfig (https://download.01.org/0day-ci/archive/20240406/202404060648.DOjOYUSf-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240406/202404060648.DOjOYUSf-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202404060648.DOjOYUSf-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/soc/qcom/smem.c:807: warning: Function parameter or struct member 'code' not described in 'qcom_smem_get_feature_code' >> drivers/soc/qcom/smem.c:807: warning: Excess function parameter 'id' description in 'qcom_smem_get_feature_code' >> drivers/soc/qcom/smem.c:840: warning: Function parameter or struct member 'code' not described in 'qcom_smem_get_product_code' >> drivers/soc/qcom/smem.c:840: warning: Excess function parameter 'id' description in 'qcom_smem_get_product_code' vim +807 drivers/soc/qcom/smem.c 797 798 /** 799 * qcom_smem_get_feature_code() - return the feature code 800 * @id: On success, we return the feature code here. 801 * 802 * Look up the feature code identifier from SMEM and return it. 803 * 804 * Return: 0 on success, negative errno on failure. 805 */ 806 int qcom_smem_get_feature_code(u32 *code) > 807 { 808 struct socinfo *info; 809 u32 raw_code; 810 811 info = qcom_smem_get(QCOM_SMEM_HOST_ANY, SMEM_HW_SW_BUILD_ID, NULL); 812 if (IS_ERR(info)) 813 return PTR_ERR(info); 814 815 /* This only makes sense for socinfo >= 16 */ 816 if (__le32_to_cpu(info->fmt) < SOCINFO_VERSION(0, 16)) 817 return -EINVAL; 818 819 raw_code = __le32_to_cpu(info->feature_code); 820 821 /* Ensure the value makes sense */ 822 if (raw_code >= SOCINFO_FC_INT_RESERVE) 823 raw_code = SOCINFO_FC_UNKNOWN; 824 825 *code = raw_code; 826 827 return 0; 828 } 829 EXPORT_SYMBOL_GPL(qcom_smem_get_feature_code); 830 831 /** 832 * qcom_smem_get_product_code() - return the product code 833 * @id: On success, we return the product code here. 834 * 835 * Look up feature code identifier from SMEM and return it. 836 * 837 * Return: 0 on success, negative errno on failure. 838 */ 839 int qcom_smem_get_product_code(u32 *code) > 840 { 841 struct socinfo *info; 842 u32 raw_code; 843 844 info = qcom_smem_get(QCOM_SMEM_HOST_ANY, SMEM_HW_SW_BUILD_ID, NULL); 845 if (IS_ERR(info)) 846 return PTR_ERR(info); 847 848 /* This only makes sense for socinfo >= 16 */ 849 if (__le32_to_cpu(info->fmt) < SOCINFO_VERSION(0, 16)) 850 return -EINVAL; 851 852 raw_code = __le32_to_cpu(info->pcode); 853 854 /* Ensure the value makes sense */ 855 if (raw_code >= SOCINFO_FC_INT_RESERVE) 856 raw_code = SOCINFO_FC_UNKNOWN; 857 858 *code = raw_code; 859 860 return 0; 861 } 862 EXPORT_SYMBOL_GPL(qcom_smem_get_product_code); 863 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
