On 05/04/2024 01:02, Mayank Rana wrote: > Hi Krzysztof > > On 4/4/2024 12:33 PM, Krzysztof Kozlowski wrote: >> On 04/04/2024 21:11, Mayank Rana wrote: >>> On some of Qualcomm platform, firmware takes care of system resources >>> related to PCIe PHY and controller as well bringing up PCIe link and >>> having static iATU configuration for PCIe controller to work into >>> ECAM compliant mode. Hence add Qualcomm PCIe ECAM root complex driver. >>> >>> Tested: >>> - Validated NVME functionality with PCIe0 and PCIe1 on SA877p-ride platform >>> >> >> RFC means code is not ready, right? Please get internal review done and >> send it when it is ready. I am not sure if you expect any reviews. Some >> people send RFC and do not expect reviews. Some expect. I have no clue >> and I do not want to waste my time. Please clarify what you expect from >> maintainers regarding this contribution. >> >> Best regards, >> Krzysztof >> > Thanks for initial comments. > yes, this is work in progress. There are still more functionalities > planned to be added as part of this driver. Although purpose of sending > initial change here to get feedback and review comments in terms of > usage of generic Qualcomm PCIe ECAM driver, and usage of MSI > functionality with it. I missed mentioning this as part of cover letter. > So please help to review and provide feedback. Thanks for explanation. Work in progress as not ready to be merged? Then I am sorry, I am not going to provide review of unfinished work. I have many more *finished* patches to review first. You can help with these too.... Best regards, Krzysztof
