On 2.04.2024 12:39 PM, Dmitry Baryshkov wrote: > On Tue, 2 Apr 2024 at 13:34, Varadarajan Narayanan > <quic_varada@xxxxxxxxxxx> wrote: >> >> drivers/clk/qcom/common.c uses devm_icc_clk_register under >> IS_ENABLED(CONFIG_INTERCONNECT_CLK). However, in kernel bot >> random config build test, with the following combination >> >> CONFIG_COMMON_CLK_QCOM=y >> and >> CONFIG_INTERCONNECT_CLK=m >> >> the following error is seen as devm_icc_clk_register is in a >> module and being referenced from vmlinux. >> >> powerpc64-linux-ld: drivers/clk/qcom/common.o: in function `qcom_cc_really_probe': >> >> common.c:(.text+0x980): undefined reference to `devm_icc_clk_register' >> >> Hence, ensure INTERCONNECT_CLK is not selected as a module. > > NAK. Please use `depends on INTERCONNECT_CLK || !INTERCONNECT_CLK` in > your Kconfig dependencies. Should icc-clk ever be built as a module? It really seems like it should be a part of the core framework.. And dependency management would be easier Konrad
