On Thu, 28 Mar 2024 at 13:12, Jun Nie <jun.nie@xxxxxxxxxx> wrote: > > Fix DSC timing and control configurations in DPU for DSI video mode. > Only compression ratio 3:1 is handled and tested. > > This patch is modified from patchs of Jonathan Marek. > > Signed-off-by: Jun Nie <jun.nie@xxxxxxxxxx> This almost looks like a joke, except it isn't the 1st of April yet. The patch lacks proper Author / Sign-off tags from Jonathan. This is pretty close to copyright infringement. I'm sorry, but I'd have to ask you to abstain from sending patches w/o prior internal review. > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 2 +- > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 12 +++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 10 +++- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 1 + > drivers/gpu/drm/msm/dsi/dsi.xml.h | 1 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 48 +++++++++++-------- > include/drm/display/drm_dsc.h | 4 ++ Ok. The feedback for the original patchset [1] was that it should be split logically. Instead you pile everything together into a single patch. This is a complete no-go. Also, this patchset lacks changelog in comparison to the previous patchseris. I don't think I'll continue the review of this patch. Please rework it properly and add corresponding changelog. [1] https://patchwork.freedesktop.org/patch/567518/?series=126430&rev=1 > 8 files changed, 56 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 6a4b489d44e5..c1b9da06dde2 100644 -- With best wishes Dmitry
