On Tue, 26 Mar 2024 at 21:43, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > When I was creating this driver, my bright mind overlooked the existence > of desc->qos_offset and decided to make up for the difference it made by > adding 21 (0x15) to the port index on SNoC and its downstream buses. > > Undo this mistake to make the indices actually mean something. So, what is the meaning of qos_port? Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > --- > drivers/interconnect/qcom/sm6115.c | 33 ++++++++++++++++++--------------- > 1 file changed, 18 insertions(+), 15 deletions(-) > > diff --git a/drivers/interconnect/qcom/sm6115.c b/drivers/interconnect/qcom/sm6115.c > index 7e15ddf0a80a..271b07c74862 100644 > --- a/drivers/interconnect/qcom/sm6115.c > +++ b/drivers/interconnect/qcom/sm6115.c > @@ -242,7 +242,7 @@ static struct qcom_icc_node crypto_c0 = { > .id = SM6115_MASTER_CRYPTO_CORE0, > .channels = 1, > .buswidth = 8, > - .qos.qos_port = 43, > + .qos.qos_port = 22, > .qos.qos_mode = NOC_QOS_MODE_FIXED, > .qos.areq_prio = 2, > .mas_rpm_id = 23, > -- With best wishes Dmitry