On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson <andersson@xxxxxxxxxx> wrote: > > From: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> > > The dp_audio read and write operations uses members in struct dp_catalog > for passing arguments and return values. This adds unnecessary > complexity to the implementation, as it turns out after detangling the > logic that no state is actually held in these variables. > > Clean this up by using function arguments and return values for passing > the data. > > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> > --- > drivers/gpu/drm/msm/dp/dp_audio.c | 20 +++++-------------- > drivers/gpu/drm/msm/dp/dp_catalog.c | 39 +++++++++++++------------------------ > drivers/gpu/drm/msm/dp/dp_catalog.h | 18 +++++++++-------- > 3 files changed, 28 insertions(+), 49 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Thanks a lot for the cleanup! -- With best wishes Dmitry
