On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson <andersson@xxxxxxxxxx> wrote: > > From: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> > > The "desc" member of struct dp_panel is zero-initialized during > allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() > never returning true. This returned boolean value is passed around but > never acted upon. > > Perform constant propagation and remove the traces of "fixed nvid". > > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> > --- > drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +- > drivers/gpu/drm/msm/dp/dp_catalog.h | 2 +- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 17 +---------------- > drivers/gpu/drm/msm/dp/dp_panel.h | 1 - > 4 files changed, 3 insertions(+), 19 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Kuogee could you possibly comment, why was this necessary at all? -- With best wishes Dmitry
