On Sun, Mar 24, 2024 at 01:13:55PM +0200, Dmitry Baryshkov wrote:
> On Sun, 24 Mar 2024 at 11:55, Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx> wrote:
> >
> > On Sat, Mar 23, 2024 at 12:56:56AM +0200, Dmitry Baryshkov wrote:
> > > The msm_gpummu.c implementation is used only on A2xx and it is tied to
> > > the A2xx registers. Rename the source file accordingly.
> > >
> >
> > There are very few functions in this file and a2xx_gpu.c is a relatively
> > small source file too. Shall we just move them to a2xx_gpu.c instead of
> > renaming?
>
> I'd prefer to keep them separate, at least within this series. Let's
> leave that to Rob's discretion.
Sounds good.
Reviewed-by: Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx>
-Akhil
>
> > -Akhil
> >
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/msm/Makefile | 2 +-
> > > drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 +-
> > > drivers/gpu/drm/msm/adreno/a2xx_gpu.h | 4 ++
> > > .../drm/msm/{msm_gpummu.c => adreno/a2xx_gpummu.c} | 45 ++++++++++++----------
> > > drivers/gpu/drm/msm/msm_mmu.h | 5 ---
> > > 5 files changed, 31 insertions(+), 29 deletions(-)
>
>
> --
> With best wishes
> Dmitry
